search

nature-of-code / noc-book

The Nature of Code book (archived repo, see README for new repo / build system!)
http://natureofcode.com
1.94k stars 365 forks source link

Fixing Issue #152 #155

Closed nonas-hunter closed 6 years ago

nonas-hunter commented 6 years ago

Just adding the <p> for issue #152

Update I am also working on replacing all the <figure> tags with the correct information. I will make a pull request soon (hopefully by the end of this week).

I believe that nelliemckesson is currently working on a new plugin to make the lazy loading work properly with all the right formatting. So for now I have modified the original plugin so it doesn't use lazy loading and just allows me to preview the sketch (just so I know I'm putting the right sketches in the right places). Once I am done implementing everything I'll put the original plugin (without modifications) back in (and make the pull request).

This has been a brief update -- I'll be back with more soon.

Thanks, Luke

P.S. This has been really fun to work on :)

shiffman commented 6 years ago

Thank you @nonas-hunter! Tagging @nelliemckesson for any comments on the "update".

nelliemckesson commented 6 years ago

Awesome, this all sounds good @nonas-hunter :) I just submitted a PR with an updated HTML template for the HTML builds which should solve the lazy-loading problems you've been having.