naturerobots / HSOS-SEP-PlantMap-2022

PlantMap Digital Logbook: A tool to support sustainable micro farming :link: https://naturerobots.github.io/HSOS-SEP-PlantMap-2022/
BSD 3-Clause "New" or "Revised" License
4 stars 5 forks source link

Place and group plants marker #203

Closed dobro929 closed 2 years ago

lsiebels commented 2 years ago

@jarkenau @pbrozi There are only 1 to 2 beds per garden, which to be honest looks a bit sad in the table and on the map. Is it possible to expand that to maybe 5 beds? The data can be the same, the coordinates would only have to be moved.

jarkenau commented 2 years ago

@lucaslootalot I could add all of those: image

It should be the same data on different positions.

lsiebels commented 2 years ago

Could you then check that the beds all have the offset coordinates and add them to the company 1 garden 1, that would be great! 😄

lsiebels commented 2 years ago

@dobro929 What kind of marker do we want to use? They don't look so suitable. 😿 2022-08-12_00h35_45

dobro929 commented 2 years ago

@lucaslootalot a green marker already exists in assets/marker😄 You can use the green one or the crops icon (sidebar), as Billie does.

lsiebels commented 2 years ago

Both doesnt look good. image image

jarkenau commented 2 years ago

@lucaslootalot Do the coordinates of the plants actually line up with the bed? Or did you manually tweak them ? :grinning:

lsiebels commented 2 years ago

I have moved the image. 🧙🏻‍♂️

lsiebels commented 2 years ago

@Anafabula Can you extend the plant_coords array of the beds with the IDs of the plants?

Edit: /cc @jarkenau

EditEdit: deprecated

lsiebels commented 2 years ago

@jarkenau @jarkenau @pbrozi It just turned out that the plant coordinates in the bed are not so useful after all. It would make more sense to have a middle coordinate of the bed, from which a marker can be created.

dobro929 commented 2 years ago

I have added a few beds to the gardens 👍🏼

lsiebels commented 2 years ago

@dobro929 works, ty 👍🏻 @jarkenau So you don't have to work on it anymore, thank you too . 😄

jarkenau commented 2 years ago

@lucaslootalot like this?

{
    "id": bed.id,
    "plant": plant_type,
    "variety": variety,
    "plants": request.build_absolute_uri(plants_url),
    "soil_humidity": soil_humidity,
    "harvest": f"{harvest} week",
    "yield": pyield,
    "health": phealth,
    "plant_coords": plant_coords,
    "mid_lat: number,
    "mid_lon: number
}
lsiebels commented 2 years ago

@jarkenau Yes and additionally please add the plant ID to the objects in plant_coords. 🙇🏻