Branchwise CI - Githubissues

amock commented 8 months ago

CI changes:

Each ROS-distro-branch has its own CI
Main branch is assigned to one CI. Dependend on which ROS distro version is currently available on main branch

This may solve the Issue: https://github.com/naturerobots/mesh_tools/issues/27

Cakem1x commented 8 months ago

Good idea! What triggered your action here, did you get annoying mails regarding failed CI runs for humble or something like this?

Cakem1x commented 8 months ago

Anyways, a two things we should talk about: melodic: I think we should remove the melodic CI (also from the bottom of the readme), as it is very end-of-life. Note that we do not have a melodic branch, so your workflow file would not do anything. humble: Did you test whether the humble CI works? I suspect that CI we cannot build it because some of the mesh_tools dependencies are not released as a deb package on ubuntu22 (i.e. lvr2). :( We'd need a bit more sophisticated CI setup that clones the lvr2 repo into the workspace; Or we work on a lvr2 release for ubuntu22 and add it to rosdep.

So my quick fix suggestion for this PR would be:

completely remove melodic (if there are objections from your side)
remove or disable humble CI (for now), until we know how to solve the issue with the lvr2 dependency

amock commented 8 months ago

Yes I got annoyed :smile: . For example: I created a branch called fix/blabla and needed to go home. So I pushed it. Then Github wrotes me an email that a pipeline has failed.

Having no CI, instead of a wrong one, would be fine with me. So later this day I will remove both humble and melodic pipelines. And the remaining noetic pipeline will be only triggered on noetic and main branch.

naturerobots / mesh_tools

Branchwise CI #30