naturerobots / mesh_tools

Tools and Messages for Annotated 3D Triangle Meshes in ROS
https://wiki.ros.org/mesh_tools
BSD 3-Clause "New" or "Revised" License
229 stars 42 forks source link

Mesh Display Fixes #32

Closed Cakem1x closed 5 months ago

Cakem1x commented 6 months ago

Hi! This PR adds a bunch of fixes for the mesh display.

I had a few segfaults here and there when I tried to visualize a mesh map that rviz gets from the mesh_navigation_server via topics.

Changes:

Related vid https://drive.google.com/file/d/1VSo_PGoJJM1n4maeS5M8u6g1W44vbPf9/view?usp=sharing

amock commented 5 months ago

Great change!

I tested everything on my computer. It is compiling. Loading static maps from files is working as before. So I see no reason to wait for merging this PR. However, what I wish to have in the future:

So that we can better test that new PRs are not causing runtime errors. If we have that, we can also think of integrate them into CI, or write separate tests. But this is an issue for another time.

-- Alex