natverse / elmr

Support for working with light and electron microscopy fly brain data
https://natverse.github.io/elmr
GNU General Public License v3.0
7 stars 3 forks source link

summarise_contribution type for 'synapse' same as 'pre' #34

Closed mmc46 closed 6 years ago

mmc46 commented 6 years ago

I get the exact same values for type='synapse' as for type='pre'. Is this a bug?


head(pnsc)
   id    n              full_name       pct     cpct
1 117 1000         Ruairi Roberts 30.303030 30.30303
2  75  403          Philipp Ranft 12.212121 42.51515
3 123  341             Fiona Love 10.333333 52.84848
4  94  290       Philipp Schlegel  8.787879 61.63636
5 121  220       Kimberly Meechan  6.666667 68.30303
6 120  196 Amelia Edmondson-Stait  5.939394 74.24242
pnsc=summarise_contribution("annotation:^glomerulus DA1 right$", type = "pre")
head(pnsc)
   id    n              full_name       pct     cpct
1 117 1000         Ruairi Roberts 30.303030 30.30303
2  75  403          Philipp Ranft 12.212121 42.51515
3 123  341             Fiona Love 10.333333 52.84848
4  94  290       Philipp Schlegel  8.787879 61.63636
5 121  220       Kimberly Meechan  6.666667 68.30303
6 120  196 Amelia Edmondson-Stait  5.939394 74.24242
pnsc=summarise_contribution("annotation:^glomerulus DA1 right$", type = "post")
> head(pnsc)
   id   n              full_name       pct     cpct
1 117 469         Ruairi Roberts 52.815315 52.81532
2  75 132          Philipp Ranft 14.864865 67.68018
3 123  95             Fiona Love 10.698198 78.37838
4  94  76       Philipp Schlegel  8.558559 86.93694
5 120  33 Amelia Edmondson-Stait  3.716216 90.65315
6  26  16             Jawaid Ali  1.801802 92.45495```
jefferis commented 6 years ago

Thanks @mmc46. Good catch!