Closed alexanderbates closed 3 years ago
Yes, I made that mistake. I kept thinking the Buhmann synapses were in FlyWire space. New push makes use of fafb2flywire.
@alexanderbates i merged this but then got a test failure on my machine. It seems that a failing test was being skipped on travis. Did you actually successfully run all tests on your own machine?
The error (message below) comes about because you assume the incoming neuron list has a column flywire.id
in its attached dataframe, but the test neuronlist looks like this:
> flywire_neuron_skeleton <- readRDS("~/dev/R/fafbseg/tests/testthat/testdata/flywire_neuron_skeleton.rds")
> flywire_neuron_skeleton[,]
id
720575940634552750 720575940634552750
Error (test-autosyn.R:132:5): flywire_neurons_add_synapses works
Error: Join columns must be present in data.
x Problem with `flywire.id`.
Backtrace:
1. testthat::expect_is(...) test-autosyn.R:132:4
5. fafbseg::flywire_neurons_add_synapses.neuronlist(...) /Users/jefferis/dev/R/fafbseg/R/autosyn.R:740:32
6. fafbseg::extract_ntpredictions.neuronlist(neurons.syn) /Users/jefferis/dev/R/fafbseg/R/autosyn.R:867:2
8. dplyr:::inner_join.data.frame(...)
9. dplyr:::join_mutate(...)
10. dplyr:::join_cols(...)
11. dplyr:::standardise_join_by(by, x_names = x_names, y_names = y_names)
12. dplyr:::check_join_vars(by$x, x_names)