natverse / fafbseg

Support functions for analysis of Drosophila connectomes especially the FAFB-FlyWire whole brain
https://natverse.org/fafbseg/
GNU General Public License v3.0
6 stars 4 forks source link

Feature/spine locations #114

Closed jefferis closed 3 years ago

jefferis commented 3 years ago

Add support for spine for synapse location data and neurotransmitter predictions

codecov[bot] commented 3 years ago

Codecov Report

Merging #114 (13dc0c8) into master (b3bb9dd) will increase coverage by 2.58%. The diff coverage is 47.36%.

:exclamation: Current head 13dc0c8 differs from pull request most recent head 86c96b4. Consider uploading reports for the commit 86c96b4 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   41.37%   43.96%   +2.58%     
==========================================
  Files          26       26              
  Lines        2562     2584      +22     
==========================================
+ Hits         1060     1136      +76     
+ Misses       1502     1448      -54     
Impacted Files Coverage Δ
R/autosyn.R 48.33% <47.36%> (+13.18%) :arrow_up:
R/utils.R 44.14% <0.00%> (+2.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3bb9dd...86c96b4. Read the comment docs.

jefferis commented 3 years ago

@alexanderbates this merged PR gives the option to request the xyz locations of neurotransmitter information in FAFB14 or FlyWire space. It would make sense for your synapse decoration routines to request the space you want rather than look after the transforms yourself.