bug in simple_python: installing skeletor twice

natverse / fafbseg

Support functions for analysis of Drosophila connectomes especially the FAFB-FlyWire whole brain

https://natverse.org/fafbseg/

GNU General Public License v3.0

6 stars 4 forks source link

bug in simple_python: installing skeletor twice #135

Closed dpacheco0921 closed 2 years ago

dpacheco0921 commented 2 years ago

In line 22-25 of function simple_python it says:

message("Installing meshparty (includes Seung lab mesh skeletonisation)")
ourpip("skeletor")
message("Installing skeletor (Philipp Schlegel mesh skeletonisation)")
ourpip("skeletor")

Should line 23 be?

ourpip("meshparty")

jefferis commented 2 years ago

Thanks a lot for spotting this @dpacheco0921! You are quite right of course although the fact that this has gone unnoticed for a while is a clue that we are not using Meshparty at the moment ...