natverse / fafbseg

Support functions for analysis of Drosophila connectomes especially the FAFB-FlyWire whole brain
https://natverse.org/fafbseg/
GNU General Public License v3.0
6 stars 4 forks source link

more informative error for flywire_xyz2id when coordinate space might be wrong #78

Closed alexanderbates closed 3 years ago

alexanderbates commented 3 years ago

This works:

# get ID
flywire.xyz = "108847.975,62454.2775,3811"
flywire.id = fafbseg::flywire_xyz2id(nat::xyzmatrix(flywire.xyz), rawcoords = TRUE)

However, earlier today I forgot that the default was not rawcoords = TRUE. If I do it with FALSE, I get this error:

flywire.xyz = "108847.975,62454.2775,3811"
flywire.id = fafbseg::flywire_xyz2id(nat::xyzmatrix(flywire.xyz), rawcoords = FALSE)
> Error in parse_url(url) : length(url) == 1 is not TRUE

And didn't immediately realise what was wrong. I also happened to get two separate inquiries over the last few days about why this function was not working, both times it was the same issue.

More informative error message needed?

alexanderbates commented 3 years ago

@tatsuookubo this was the issue we had earlier

jefferis commented 3 years ago

closed by #82