Feature/neuroglancer colour

natverse / fafbseg

Support functions for analysis of Drosophila connectomes especially the FAFB-FlyWire whole brain

https://natverse.org/fafbseg/

GNU General Public License v3.0

6 stars 4 forks source link

Feature/neuroglancer colour #91

Closed SiqiFang closed 3 years ago

SiqiFang commented 3 years ago

Add neuroglancer colour

jefferis commented 3 years ago

Thanks a lot for the PR @SiqiFang. So we don't forget, here are the additions to finish this off that I can recall thinking about:

[x] make sure that the colours are specified as hex values
[x] figure out what to do if the scene has no ids
[x] figure out what to do if the colours conflict with the ids
[x] add some tests

jefferis commented 3 years ago

Thanks @SiqiFang this is all good now! When you have a moment, take at the final changes that I made to get it to pass R CMD check. There were a couple of namespace issues and a missing argument in the docs iirc. I also added more examples/tests.