natverse / nat.jrcbrains

Janelia Research Campus Bridging Registrations for Drosophila Brains
https://natverse.github.io/nat.jrcbrains
Other
0 stars 0 forks source link

Implement `download_saalfeldlab_registrations` #2

Closed SridharJagannathan closed 5 years ago

SridharJagannathan commented 5 years ago

Implement the function download_saalfeldlab_registrations to automatically download the transformations (.nii) for the jrc-2018-brain-templates and put them into proper folder names. Also consider adding the (.h5) formats for the registrations as well.

SridharJagannathan commented 5 years ago

@jefferis: Before implementing #1, I wanted to standardise stuff a bit, so I opened this issue, so I can have the .nii and .h5 formats in standard folders. Please take a look at the preliminary implementation for the .nii files. I will add the .h5 format later once you give the go ahead.

jefferis commented 5 years ago

Ok. I wasn’t sure whether to abandon the nii format altogether or (as you’re suggesting) to support both in parallel.

Sent from my iPhone

On 26 Jun 2019, at 20:37, Sridhar Jagannathan notifications@github.com wrote:

@jefferis: Before implementing #1, I wanted to standardise stuff a bit, so I opened this issue, so I can have the .nii and .h5 formats in standard folders. Please take a look at the preliminary implementation for the .nii files.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

SridharJagannathan commented 5 years ago

@jefferis Can you please check this and accept the PR, I have tested it from my side and seems Ok, once you confirm I will focus on #1