fix downloading of git repos when no git user has been set

[jefferis]

This seems to be a Windows specific issue and manifests like this:

> nat.flybrains::download_jefferislab_registrations()
Error in default_signature(repo) : 
  Error in 'git2r_signature_default': Failed to parse signature - Signature cannot have an empty name or email

when no git user has been set (one seems to be made up on mac).

[jefferis]

Hold off on that submission @ajdm, one more fix required!

[jefferis]

OK @ajdm, this tested OK on Windows so I think we are good to go to prepare a bugfix release for CRAN. Thanks! G.

[jdmanton]

There's one issue in that the version of nat available on CRAN is insufficient on Mac OS X (https://cran.r-project.org/web/checks/check_results_nat.templatebrains.html). Do we just ignore and see if Ripley et al will take it anyway?

[jefferis]

As usual an rgl problem. Don't know why the build machine can't reliably have this. I am considering having nat check on load whether it is running interactive and, if yes, setting rglUSENULL to T. There is a branch for this on nat's GitHub. Thoughts? G.

Sent from my iPhone

On 5 Dec 2015, at 19:08, James Manton notifications@github.com wrote:

There's one issue in that the version of nat available on CRAN is insufficient on Mac OS X (https://cran.r-project.org/web/checks/check_results_nat.templatebrains.html). Do we just ignore and see if Ripley et al will take it anyway? — Reply to this email directly or view it on GitHub.

[jdmanton]

It looks like they're not going to fix the rgl issues any time soon, so I reckon that's a good idea.

[jefferis]

Do you want to try that nat branch out then, maybe merge it into master? It seems fairly straightforward. I guess my only concern is that I might have overlooked something when running batch jobs eg the NBLAST server. G.

Sent from my iPhone

On 5 Dec 2015, at 21:46, James Manton notifications@github.com wrote:

It looks like they're not going to fix the rgl issues any time soon, so I reckon that's a good idea. — Reply to this email directly or view it on GitHub.

[jdmanton]

Okay, I'll give that a go. In the mean time, I've submitted as is to CRAN, as I think they'll take it anyway.

[jdmanton]

On CRAN now.