Closed SridharJagannathan closed 4 years ago
Hi @SridharJagannathan, I see the problem, but that's not the solution. The bug is here:
That should have read:
nclear3d(plotengine=plotengine)
@jefferis Thanks for this, I see your point, isn't it usually the convention that when a function has one formal argument, followed by ellipsis, people usually can supply that argument without naming them, or to frame it better which is usually preferred,
nclear3d <- function(plotengine = getOption('nat.plotengine'),...)
where people can simply usenclear3d(plotengine)
ornclear3d <- function(...,plotengine = getOption('nat.plotengine'))
It's because nclear3d
is actually a wrapper around rgl::clear3d
and most of the time you don't need to touch the plotengine
argument because the default value works fine. You see examples of ellipsis first where the subsequent arguments are options rather than the main deal. c()
is an example of this.
Things that still need to be done:
add=TRUE
wire3d.shapelist3d
@jefferis: I have updated all the comments per our discussion, please review this and merge the same.
Thank you!
Updated for #421 @jefferis:
wire3d
that masks the function with the same name fromrgl
and will pass the call to eitherrgl
orplotly
dependent on the option ofnat.plotengine
.