search

natverse / nat

NeuroAnatomy Toolbox: An R package for the (3D) visualisation and analysis of biological image data, especially tracings of single neurons.
https://natverse.org/nat/
64 stars 28 forks source link

Fix/xyz.character nas #451

Closed jefferis closed 3 years ago

jefferis commented 3 years ago

@alexanderbates this is an important fix that could affect your spreadsheet updates. Specifically xyzmatrix.character() was previously silently dropping rows with no/bad values. If these results were then used to calculate e.g. new ids in another column without checking the number of replacement values, they would end up misaligned.

alexanderbates commented 3 years ago

Noted!

jefferis commented 3 years ago

The CI failure is nothing to do with this change, but rather due to changes in rgl::wire3d. I will need to update the docs, but more generally, I wonder if we should be removing wire3d()

codoc mismatches from documentation object 'wire3d':
wire3d.mesh3d
  Code: function(x, ..., front = "lines", back = "lines")
  Docs: function(x, override = TRUE, meshColor = c("vertices", "edges",
                 "faces", "legacy"), ...)
  Argument names in code not in docs:
    front back
  Argument names in docs not in code:
    override meshColor
  Mismatches in argument names:
    Position: 2 Code: ... Docs: override
    Position: 3 Code: front Docs: meshColor
    Position: 4 Code: back Docs: ...
coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.05%) to 81.312% when pulling f56a80af85fb33fa9fe47f014834ba8576df32fd on fix/xyz.character-nas into 0efa75bd06850b6a29b136474284461bd9c336b3 on master.