search

natverse / nat

NeuroAnatomy Toolbox: An R package for the (3D) visualisation and analysis of biological image data, especially tracings of single neurons.
https://natverse.org/nat/
64 stars 28 forks source link

Neurons matched by first column in case of generic row names in… #467

Closed dokato closed 2 years ago

dokato commented 3 years ago

Neurons matched by the first column in case of generic row names in data.frame - following yours yesterday's idea.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.02%) to 81.441% when pulling 8153c042c153891f69ca006b0d48ed91a539da5a on dokato:neuronlistindex into a155984fa0cc6ea226c021ab5278e48007426219 on natverse:master.

codecov[bot] commented 3 years ago

Codecov Report

Merging #467 (ae03ae5) into master (8d8b28c) will decrease coverage by 0.04%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
- Coverage   76.95%   76.91%   -0.05%     
==========================================
  Files          47       47              
  Lines        5842     5848       +6     
==========================================
+ Hits         4496     4498       +2     
- Misses       1346     1350       +4
Impacted Files Coverage Δ
R/neuronlist.R 81.30% <85.71%> (-0.87%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d8b28c...ae03ae5. Read the comment docs.

jefferis commented 2 years ago

@dokato I'm sorry this PR got dropped. Do you think it's still ready for merge?

dokato commented 2 years ago

Yes, I tested it even now, it should be okay.