search

natverse / nat

NeuroAnatomy Toolbox: An R package for the (3D) visualisation and analysis of biological image data, especially tracings of single neurons.
https://natverse.org/nat/
62 stars 26 forks source link

Fix handling of null elements in xyzmatrix.list #488

Closed jefferis closed 2 years ago

jefferis commented 2 years ago

example from fafbseg

> fn=flywire_nuclei(c("720575940613259167", "720575940625038394", "720575940635678832", 
+                    "720575940636680282"), rawcoords = T)
Error: Problem with `mutate()` input `..1`.
`..1 = across(ends_with("position"), function(x) xyzmatrix2str(flywire_nm2raw(x)))`.
x Can't convert <list_of<integer>> to <list<integer>>.
codecov[bot] commented 2 years ago

Codecov Report

Merging #488 (7c61966) into master (bfee840) will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   75.69%   75.75%   +0.05%     
==========================================
  Files          48       48              
  Lines        5897     5899       +2     
==========================================
+ Hits         4464     4469       +5     
+ Misses       1433     1430       -3
Impacted Files Coverage Δ
R/xyzmatrix.R 93.60% <100.00%> (+2.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bfee840...7c61966. Read the comment docs.