search

natverse / nat

NeuroAnatomy Toolbox: An R package for the (3D) visualisation and analysis of biological image data, especially tracings of single neurons.
https://natverse.org/nat/
62 stars 26 forks source link

Minor edit of stitch_neurons edge cases #493

Closed dokato closed 2 years ago

dokato commented 2 years ago

as function promises to return a neuron, it should return a neuron - fixes #490

codecov[bot] commented 2 years ago

Codecov Report

Merging #493 (13bd461) into master (ad5717c) will increase coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head 13bd461 differs from pull request most recent head 595e1c0. Consider uploading reports for the commit 595e1c0 to get more accurate results

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   75.75%   75.77%   +0.02%     
==========================================
  Files          48       48              
  Lines        5899     5900       +1     
==========================================
+ Hits         4469     4471       +2     
+ Misses       1430     1429       -1
Impacted Files Coverage Δ
R/neuron.R 83.87% <100.00%> (+0.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad5717c...595e1c0. Read the comment docs.

jefferis commented 2 years ago

Do you want to add a test for the new behaviour?

dokato commented 2 years ago

Sure, added!