search

natverse / nat

NeuroAnatomy Toolbox: An R package for the (3D) visualisation and analysis of biological image data, especially tracings of single neurons.
https://natverse.org/nat/
64 stars 29 forks source link

Need to integrate as.seglist test fix in CRAN release #494

Closed jefferis closed 2 years ago

jefferis commented 2 years ago

CRAN is still on 1.8 branch nat may be removed from CRAN by 2022-04-15 unless #492 is ported to https://github.com/natverse/nat/tree/1.8. @dokato I am not sure if you might have the chance to do this?

dokato commented 2 years ago

Sure, I'll have a look tomorrow.

dokato commented 2 years ago

@jefferis do you want me to make and submit a CRAN build? BTW why don't we push out v 1.10?

jefferis commented 2 years ago

@jefferis do you want me to make and submit a CRAN build? BTW why don't we push out v 1.10?

Thank you very much. It would be great if you could test this on the win builder service in addition to the regular GitHub tests. I will need to submit the update — or at least approve it — as the package maintainer.

Yes it would be great if we could submit a 1.10 release but there some changes that I think are likely to cause issues on CRAN (even including the extended vignettes) so I think that's a bigger project.

dokato commented 2 years ago

Argh, I rushed a little or rather didn't know that this win-builder service can be used independently of cran submission. I pushed the updated version of nat 1.8.18 to both. You may get some confirmations to your maintainer email @jefferis

jefferis commented 2 years ago

I think we can close this @dokato ?

dokato commented 2 years ago

Yup, this is completed