natverse / nat

NeuroAnatomy Toolbox: An R package for the (3D) visualisation and analysis of biological image data, especially tracings of single neurons.
https://natverse.org/nat/
64 stars 29 forks source link

Fix/matching by col numeric #504

Closed jefferis closed 1 year ago

jefferis commented 2 years ago
codecov[bot] commented 2 years ago

Codecov Report

Merging #504 (2b36409) into master (49d578d) will increase coverage by 1.14%. The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   75.73%   76.88%   +1.14%     
==========================================
  Files          48       48              
  Lines        5906     5914       +8     
==========================================
+ Hits         4473     4547      +74     
+ Misses       1433     1367      -66     
Impacted Files Coverage Δ
R/neuronlist.R 80.86% <70.00%> (-0.44%) :arrow_down:
R/neuron-io.R 84.71% <0.00%> (+1.55%) :arrow_up:
R/amiralandmarks-io.R 90.74% <0.00%> (+9.25%) :arrow_up:
R/neuronlistfh.R 79.47% <0.00%> (+30.52%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

dokato commented 1 year ago

Doesn't as.character(bit64::as.integer64((x))) solve the problem?

jefferis commented 1 year ago

Doesn't as.character(bit64::as.integer64((x))) solve the problem? @dokato yes some variation on that could help, but I have so far resisted to make base nat depend on the bit64 package.