natverse / nat

NeuroAnatomy Toolbox: An R package for the (3D) visualisation and analysis of biological image data, especially tracings of single neurons.
https://natverse.org/nat/
62 stars 26 forks source link

Switching off patch in codecov #507

Closed dokato closed 1 year ago

dokato commented 1 year ago

Not sure if patch checks of coverage are necessarily needed in some cases. More important is the overall coverage of the whole package. And failing reports of them are quite annoying. I decided to switch them off, but we can alternatively lower the threshold, or something.

codecov[bot] commented 1 year ago

Codecov Report

Merging #507 (d66d08a) into master (46e4626) will not change coverage. The diff coverage is n/a.

:exclamation: Current head d66d08a differs from pull request most recent head 373db02. Consider uploading reports for the commit 373db02 to get more accurate results

@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   76.90%   76.90%           
=======================================
  Files          48       48           
  Lines        5906     5906           
=======================================
  Hits         4542     4542           
  Misses       1364     1364           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jefferis commented 1 year ago

Thanks @dokato. I agree the patch ones are sometimes a bit sensitive at the current threshold. What is it?

jefferis commented 1 year ago

How about setting like this?

patch:
      default:
        informational: true

(from https://docs.codecov.com/docs/common-recipe-list)

dokato commented 1 year ago

Ow yeah, I like it better too 👍 Thanks!

jefferis commented 1 year ago

Thanks!