natverse / neuprintr

R client utilities for interacting with the neuPrint connectome analysis service
http://natverse.org/neuprintr
3 stars 3 forks source link

Adding the synonyms field in metadata #123

Closed romainFr closed 4 years ago

romainFr commented 4 years ago

The upcoming 1.1 version of the database contains a synonyms field that stores alternate type names. This just adds it to the output of neuprint_get_meta if it exists

jefferis commented 4 years ago

Thanks @romainFr, the adjacency matrix example fix is based on the new names which are not on the public server to my knowledge. So do we wait until they are?

romainFr commented 4 years ago

Ah, sorry about that. Yes, let me revert that.

romainFr commented 4 years ago

@jefferis any idea what the failure on 3.6.3 relates to? I suspect it's linked to changes in the latest dplyr release but I haven't really tracked it down.

jefferis commented 4 years ago

@jefferis any idea what the failure on 3.6.3 relates to? I suspect it's linked to changes in the latest dplyr release but I haven't really tracked it down.

Sorry I missed this. It's either down to the version of the tibble package or stringsAsFactors=FALSE now being the default.

romainFr commented 4 years ago

Tracked that down finally: for future reference, when collating empty data frames with cbind, in 3.6 the names of the resulting object is NULL, whereas it's character(0) in 4.0. And dplyr::bind_rows errors on data frames with NULL names in the latest dplyr version