search

natverse / neuprintr

R client utilities for interacting with the neuPrint connectome analysis service
http://natverse.org/neuprintr
3 stars 3 forks source link

WIP : wrappers for path related functions #17

Closed romainFr closed 4 years ago

romainFr commented 4 years ago

To pull all paths of a certain length range or all the shortest paths between two bodies.

For now I just wrapped the queries for now, I still need to add a nice output, so it's not ready for merging.

jefferis commented 4 years ago

Hi @romainFr thanks for this start. @SridharJagannathan and I will be working seriously on the repo from start of next week. To assist with development we have often found it helpful to create feature branches on the main repo (i.e. natverse/neuprintr in this case) rather than working with PRs on your own repos. The reason is that three of us can interleave commits on a feature branch here, whereas for a PR hosted in your repo, we can only merge or comment. I've sent you an invite for this repo. I think you should also add yourself as an author rather than contributor.

jefferis commented 4 years ago

Of course you can still continue to make small self-contained PRs as before.

romainFr commented 4 years ago

Both functions now output a data frame with columns "to", "from", "weight", "name.to", "name.from", which should be easily parsable by most network visualization tools.

romainFr commented 4 years ago

One thing that one still might want to add is the option to restrict the paths within a given ROI (or set of ROIs)

romainFr commented 4 years ago

Tests/examples should be added, but I'm going to merge as it's working/useful (and I'll start working off natverse/neuprintr branches from now on)