neuprint_get_neuron_names should always return as many outputs as inputs

natverse / neuprintr

R client utilities for interacting with the neuPrint connectome analysis service

http://natverse.org/neuprintr

3 stars 3 forks source link

neuprint_get_neuron_names should always return as many outputs as inputs #65

Closed jefferis closed 4 years ago

jefferis commented 4 years ago

neuprint_get_neuron_names currently had all_segments=FALSE as a default. This causes trouble if you have an input vector that contains some fragments. Perhaps the best thing would be to fill any missing values with NA

jefferis commented 4 years ago

This means actually returning NAs for all missing values as promised in docs.

jefferis commented 4 years ago

See also change from @alexanderbates in 2c74fefd5edf6eedb56746b4121f17504f8e6eb7 setting all_segments=FALSE.