search

natverse / neuprintr

R client utilities for interacting with the neuPrint connectome analysis service
http://natverse.org/neuprintr
3 stars 3 forks source link

Update/simplify extract_connectivity_df #7

Closed romainFr closed 4 years ago

romainFr commented 4 years ago

It was failing for me because neuprint now does not return a pre (or post) field if the value is 0.

romainFr commented 4 years ago

That is, for the latest version of the server (13000), but that does not break the old version (11000)

romainFr commented 4 years ago

As a side note, there are some functions failing in the new server (notably neuprint_connection_table) because of changes in the data model

jefferis commented 4 years ago

Thanks @romainFr. I will try to review as soon as possible. As you note there are a number of functions that have been broken by the new data model. Are you aware of any versioning scheme for neuPrint that might allow us to match the API client functions to the API version?

romainFr commented 4 years ago

Not that I am aware of. The "version" function in the API returns the same thing for both servers (0.1.0). I think their idea is that only the new data model will ever be public facing.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Friday, December 20, 2019 4:12 PM, Gregory Jefferis notifications@github.com wrote:

Thanks @romainFr. I will try to review as soon as possible. As you note there are a number of functions that have been broken by the new data model. Are you aware of any versioning scheme for neuPrint that might allow us to match the API client functions to the API version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

jefferis commented 4 years ago

Thanks for that note @romainFr. Versioning will apparently come when the API is a bit more stable.