search

natverse / neuprintr

R client utilities for interacting with the neuPrint connectome analysis service
http://natverse.org/neuprintr
3 stars 3 forks source link

Add "upstream" and "downstream" fields in extract_connectivity_df #93

Closed romainFr closed 4 years ago

romainFr commented 4 years ago

This is a non breaking change (fixing a bug on experimental versions of the server), preparing for future releases of neuprint, in which :Neuron nodes and their associated :roiInfo have two extra fields: "upstream" and "downstream". Those fields represent actual synapse counts (rather then presynaptic/postsynaptic terminals), so they match the "weight" value (until now, the total "pre" value was always more than the "weight" value because of polyadic synapses). Making a PR mostly to document the change.

jefferis commented 4 years ago

Hi @romainFr, builds are currently failing because these extra columns violate some test case expectations. Should this change definitely be live at the moment since most people are using the externally visible server and these columns are just full of zeros?

romainFr commented 4 years ago

Hi @jefferis , I see, sorry about that. This would be breaking for anyone using the test server. So we could either create a separate branch for test server users, or edit the tests.

jefferis commented 4 years ago

Is there any kind of version information associated with the test server @romainFr? We probably just need to relax the test baselines for now.

romainFr commented 4 years ago

neuprint_version() on neuprint-test.janelia.org returns "0.1.0", like neuprint.janelia.org. Alternatively one could query the database for the keys available in a :Neuron node. That might be a bit of an overkill though (and would be trickier for roiInfo).