search

natverse / neuprintr

R client utilities for interacting with the neuPrint connectome analysis service
http://natverse.org/neuprintr
3 stars 3 forks source link

Flexible fields for roiInfo #95

Closed romainFr closed 4 years ago

romainFr commented 4 years ago

Incorporate upstream/downstream as needed (depending on their presence on the server) in neuprint_get_meta, fixes tests. This rests on a couple of utility functions, neuprint_get_fields that checks for the presence of fields in neuron objects, and dfFields which translate them into our usual column names.

jefferis commented 4 years ago

Thanks for this @romainFr. I can’t review now, but did you memoise the check for which fields must be used?

romainFr commented 4 years ago

I didn't memoise, but the function that pulls the fields is not called inside repeated calls (like extract_connectivity_df) and it's pretty fast. Let me know if you still think memoise would help.

jefferis commented 4 years ago

Hi @romainFr, thanks a lot for this! I'm still reviewing, but I did think it was worth memoising.