natverse / rcatmaid

R package providing API access to the CATMAID web image annotation tool
https://natverse.github.io/rcatmaid
GNU General Public License v3.0
9 stars 6 forks source link

Feature/update neurons #138

Closed jefferis closed 2 years ago

jefferis commented 5 years ago

Still thinking about these additions from @alexanderbates

jefferis commented 5 years ago

Split away from #130

jefferis commented 5 years ago

@alexanderbates I would suggest combining these into a single function e.g. update_neuronlist. In general if a function does something closely related and returns the same kind of object then I would consider combining. In this case you have an argument to control which kind of update is required (with a default to update everything). Note also that read.neurons.catmaid actually fetches neuron names.

jefferis commented 5 years ago

@alexanderbates I would suggest combining these into a single function e.g. update_neuronlist. In general if a function does something closely related and returns the same kind of object then I would consider combining. In this case you have an argument to control which kind of update is required (with a default to update everything). Note also that read.neurons.catmaid actually fetches neuron names.

alexanderbates commented 5 years ago

Okay, done!