search

natverse / rcatmaid

R package providing API access to the CATMAID web image annotation tool
https://natverse.github.io/rcatmaid
GNU General Public License v3.0
9 stars 6 forks source link

reroot method added #172

Open dokato opened 3 years ago

dokato commented 3 years ago

related to https://github.com/natverse/nat/pull/463

jefferis commented 3 years ago

Looks good. Thanks @dokato! Can you add a test when https://github.com/natverse/nat/pull/463 is merged?

jefferis commented 3 years ago

Oh this is the sort of thing where one should put a min version on the dependency, but perhaps we can leave this time since there are a few things coming up with nat.

dokato commented 3 years ago

Sure, reroot test added now.

dokato commented 3 years ago

I guess this fails as this is not yet merged? https://github.com/natverse/nat/pull/463

jefferis commented 3 years ago

That's right. Is the Nat PR all done?

dokato commented 3 years ago

Yes, I addressed all your comments. All check seem to pass too.