natysoz / expo-images-picker

Multiple Asset Photos Videos selecting package for Expo SDK
MIT License
95 stars 35 forks source link

Add more flexibility for the style of the Screen and Widget #40

Closed jte0711 closed 2 years ago

jte0711 commented 2 years ago

Hi, I think it would be great if we could let user to customise the component style a bit more (e.g borderRadius). Currently we limit them with a few styles such as margin, bgcolor, and widgetWidth.

I have a PR about adding borderRadius to the style. #39

natysoz commented 2 years ago

ok will merge after u fix conflicts

natysoz commented 2 years ago

we can send in style object and assign default one if none if u want to create a pr ur welcome

jte0711 commented 2 years ago

@natysoz , yea sure. I can work on it when I'm free

natysoz commented 2 years ago

I remove the border u added because it was typed wrong and make issues with the build ,

Let's work together on adding an object of styling for the screen so we won't have to send border separate or later on border color or ....

jte0711 commented 2 years ago

I remove the border u added because it was typed wrong and make issues with the build ,

ok no problem. Do you mind sharing what was wrong with the type?

Let's work together on adding an object of styling for the screen so we won't have to send border separate or later on border color or ....

Yea sure. how do you want it to look like? will it be part of the current widgetStyles?

natysoz commented 2 years ago

yhea i think , we can send in an object and just pass it on and spread it , like i did with th default navigator buttons

bengold14 commented 2 years ago

Hi - just wanted to say thanks for the component, I would also love a way to add a border radius to the photos in the selection. Let me know if you need help with the PR

jte0711 commented 2 years ago

hi @natysoz, I opened a PR about customizing the screen style and the widget style, please check it here #43

natysoz commented 2 years ago

hi sorry for the delay ill look at this pr today

jte0711 commented 2 years ago

hi sorry for the delay ill look at this pr today

no problem, let me know if there's anything wrong with it