naucon / grav-plugin-cookieconsent

Grav plugin to alerting users about the use of cookies on your website. Integration of the popular js lib cookie consent by insites.
MIT License
20 stars 4 forks source link

new features and overall cleanup #2

Closed jimblue closed 6 years ago

jimblue commented 7 years ago

Hi @naucon !

Since your last update about language, I was curious to see how you did it.

And by looking at your code I saw many little things to improve. So I decide to work on it this morning:

I've test it and it's working like a charm.

Looking forward the merge 😄 !

Cheers

jimblue commented 7 years ago

Hi @naucon did you see the PR? 😄

jimblue commented 7 years ago

Hi @naucon, I've reviewed all your comment, what do you think?

naucon commented 7 years ago

Hi @jimblue, thank you for your answers. Sorry for letting you wait. Only on the weekend I have the time to take care about my open source projects.

At the moment I would like to add the

For disabling the buildInJs (JS file + Template) or buildInCss (CSS file) I don't the the point. But I am open for convincing arguments.

jimblue commented 7 years ago

No worries for the delay.

About disabling the buildInJs (JS file + Template) and/or buildInCss (CSS file) it's important for people using bundler like webpack. (I will add JS and CSS to my package myself... if I can't disable them in your plugin they will be loaded twice...)