search

naught101 / sobol_seq

python implementation of Sobol' sequence generator
MIT License
67 stars 29 forks source link

use 0-based skip parameter #19

Closed michaelosthege closed 4 years ago

michaelosthege commented 4 years ago

Specifying skip=1 did not skip anything compared to not specifying skip.

I added the +1 as suggested in #14 and set the default to skip=0.

I've incremented the version to 0.2.0 since this shifts any existing skip specification by 1.

The code, tests & docstrings are still not Pythonic, but that's something for another day..

naught101 commented 4 years ago

Awesome, thank you Michael. I added and __init__.py so that pytest works too.