search

naugtur / blocked-at

Detects node eventloop block and reports where it started
MIT License
321 stars 25 forks source link

Filter stacktrace on newer NodeJS #33

Closed HonzaMac closed 2 years ago

HonzaMac commented 2 years ago

NodeJS changed way how stacktrace look for async hooks: Example:

    at AsyncHook.init (/www/node_modules/blocked-at/index.js:31:11)
    at TCP.emitInitNative (node:internal/async_hooks:201:43)
    at Socket.connect (node:net:993:7)
    at Object.connect (node:net:203:17)
    at Object.netConnect [as createConnection] (/www/node_modules/puppeteer/node_modules/ws/lib/websocket.js:1006:14)
    at new ClientRequest (node:_http_client:326:45)
    at request (node:http:96:10)
HonzaMac commented 2 years ago

Cc @naugtur ?

naugtur commented 2 years ago

UX fail, I gave you a review on the phone hours after your submission and now (desktop) I see it's pending...

Also, thanks for contributing. It's a much needed update.

naugtur commented 2 years ago

Last round of questions, I'll merge and release once we finish talking :)

sraka1 commented 1 year ago

@naugtur this doesn't seem like it was ever release to npm?