search

naugtur / npm-audit-resolver

Apache License 2.0
119 stars 28 forks source link

"yargs-parser" prototype pollution npm vulnerability #26

Closed lenymo closed 4 years ago

lenymo commented 4 years ago

In a somewhat ironic development, npm-audit-resolver itself is affected by the following npm vulnerability advisory: https://www.npmjs.com/advisories/1500

I tested this vulnerability on an old version (1.4.1) as well as the latest available release (2.2).

Coped from the advisory above:

Prototype Pollution Affected versions of yargs-parser are vulnerable to prototype pollution. Arguments are not properly sanitized, allowing an attacker to modify the prototype of Object, causing the addition or modification of an existing property that will exist on all objects. Parsing the argument --foo.proto.bar baz' adds a bar property with value baz to all objects. > This is only exploitable if attackers have control over the arguments being passed to yargs-parser.

Remediation Upgrade to versions 13.1.2, 15.0.1, 18.1.1 or later.

johanneswuerbach commented 4 years ago

I created https://github.com/naugtur/npm-audit-resolver/pull/27, but it requires a bunch of related bumps to get resolved 🤞

joebowbeer commented 4 years ago

This is the only vulnerability remaining in our app.

orliesaurus commented 4 years ago

Same here @joebowbeer

lenymo commented 4 years ago

Thanks for fixing this! 👍

naugtur commented 4 years ago

Sorry for the delay, life came and messed with my hobbies ;)