naumanjaved / fingerprint_maps

Create "haplotype maps" of variants in order to use with Picardtools Crosscheck_Files utility, which allows for robust genotyping of functional genomic data.
24 stars 9 forks source link

Use proper VCF parsing tools #2

Closed yfarjoun closed 6 years ago

yfarjoun commented 6 years ago

Several places in the scripts make use of "magic numbers" and other shortcuts that mean that despite seeming to be general, they are highly tuned to the use of specific resource files.

It would be better to use an actual VCF parsing package (e.g. https://pyvcf.readthedocs.io/en/latest/) instead. The code will be cleaner and probably shorter as well.