search

naumch1k / one-fall

Landing page for ONE FALL, Salem-based melodic punk and hardcore quartet has rapidly made a mark in New England
https://develop--one-fall.netlify.app/
0 stars 0 forks source link

BUG: ESC key closes modal and exits full-screen on Firefox and Safari #11

Closed naumch1k closed 2 months ago

naumch1k commented 3 months ago

Describe the bug

Pressing the Escape key to close the modal window also exits the browser's full-screen mode on Firefox and Safari

Environment

Desktop:

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://develop--one-fall.netlify.app/
  2. Click on MERCH link in the main navigation menu
  3. Click on any merch image to open a modal window
  4. Press ESC key

Expected behavior

The modal window should close when the ESC key is pressed, but the browser window should remain in full-screen mode

Screenshots, Video, GIFs

https://github.com/naumch1k/one-fall/assets/76534205/67622f54-bc96-4796-a67c-4392132550d8

github-actions[bot] commented 3 months ago

@naumch1k 👋

Thanks for dropping in with the issue! Our team is ready to dive into it as soon as possible! 🚀

If you would like to work on this issue, please wait for us to decide if it's ready; hang tight until we've given it the green light. The issue will be ready to work on once we remove the Needs triage label.

To claim an issue that does not have the Needs triage label, please leave a comment that says ".take". If you have any questions, please follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

Let's make some magic together! ✨

github-actions[bot] commented 3 months ago

@naumch1k 👋 Thanks for showing interest in this issue ❤️ This ticket seems to be in good hands with another contributor.