search

naumch1k / one-fall

Landing page for ONE FALL, Salem-based melodic punk and hardcore quartet has rapidly made a mark in New England
https://develop--one-fall.netlify.app/
0 stars 0 forks source link

FEAT: Add Press Section #12

Closed Yura33-dev closed 3 months ago

Yura33-dev commented 3 months ago

Description

This PR implements a brand new component which represents rock-band from press.

Changes Made

  1. Refactored useEventLink and renamed it for useFormattedDate. This is shared hook for EventLink and PressCard components
  2. Created data.json in Press section with data for cards.
  3. Created Press section and implemented list of PressCard.
netlify[bot] commented 3 months ago

Deploy Preview for one-fall ready!

Name Link
Latest commit b32344a32c3303dd6d0fb55177428bb8b92ee39d
Latest deploy log https://app.netlify.com/sites/one-fall/deploys/66898899bbb99f0008906ebd
Deploy Preview https://deploy-preview-12--one-fall.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Yura33-dev commented 3 months ago

Hey, @naumch1k! I have added a new commits with some changes which we were talking at last meeting. I hope, I didn`t forget something) Please, make a review when you will have a minute for it. Thanks a lot)

Yura33-dev commented 3 months ago

Hey, @naumch1k 👋

I have finished with enhancements which you talked above. Could you check it when you have time, please?

Also, I have refactored PressCard / PressList a bit. Is it ok?

UPD: I see my next task right now (List UI component) and I have realized that I did it in correct way (I hope 😅). Of course, I will refactor my PressList a bit . So, it will be just List according to my future improvements.

Yura33-dev commented 3 months ago

Hey @Yura33-dev, thanks for implementing the suggested changes and refactoring on FormattedDate.

Please take a look at the commits I just added. These reflect minor changes to our design and ensure consistent code formatting and color variable usage.

If these changes look good to you, I think we’re ready to merge!

Yes! Let`s merge it!)