naumch1k / one-fall

Landing page for ONE FALL, Salem-based melodic punk and hardcore quartet has rapidly made a mark in New England
https://develop--one-fall.netlify.app/
0 stars 0 forks source link

BUGFIX: Prevent Hover Effects on Main Navigation Links and Sidebar Social Links on Touch Devices #37

Closed naumch1k closed 2 months ago

naumch1k commented 2 months ago

Description

This pull request fixes an issue where hover effects were mistakenly applied to main navigation and sidebar social links after closing a modal on touch devices. The problem occurred because touch interactions may sometimes activate hover styles, causing elements beneath to appear hovered even though they were not directly interacted with.

To fix this, @media (any-hover: hover) is used to apply hover styles only on devices that support true hover interactions, like a mouse or touchpad. This prevents the unintended hover effects on touch devices.

Task Link

This pull request closes #35

Screenshots, GIFs, or videos

This fix also resolves the same issue when the modal is closed by tapping on the backdrop above the social links sidebar.

https://github.com/user-attachments/assets/a03aa2ce-3495-4528-99e0-c7e71ff435de

netlify[bot] commented 2 months ago

Deploy Preview for one-fall ready!

Name Link
Latest commit f98ae0832e9059843ac54e319f71df174fe65f1e
Latest deploy log https://app.netlify.com/sites/one-fall/deploys/66baa00ee8696d00089ec27b
Deploy Preview https://deploy-preview-37--one-fall.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.