naushadh / hive-metastore

Apache Hive Metastore as a Standalone server in Docker
Apache License 2.0
64 stars 25 forks source link

Allow DATABASE_URL to be provided #8

Open naude-r opened 10 months ago

naude-r commented 10 months ago

would it be possible to allow an optional DATABASE_URL to be provide? this is mostly to configure jdbc url that differs slightly from the norm, e.g. mssql: jdbc:sqlserver://localhost:1433;DatabaseName=hive_metastore;

using the existing env variables result in an error: Underlying cause: com.microsoft.sqlserver.jdbc.SQLServerException : The port number 1433/hive_metastore is not valid.

if DATABASE_URL is specified then the other connection related env can be skipped.

naushadh commented 3 weeks ago

Apologies for the very long delay; from your post it's evident you're trying to use MS-SQL with HMS; however, that's may break for more than just the connection url because the image is only configuring the Postgres driver. Got a couple questions for you

  1. Did https://github.com/naushadh/hive-metastore/pull/9 make the image work with MS-SQL server?
  2. Are you still interested in seeing this issue resolved?
naude-r commented 3 weeks ago

@naushadh thank you for the response. yes, the PR did solve the issue.

unfortunately we've since moved on to other solutions and do not require this anymore.

naushadh commented 3 weeks ago

Understandable; just for curiosity, do you mind sharing the other solution that you'd moved to?

naude-r commented 3 weeks ago

sure, the client moved to a cloud managed instance.