search

nautechsystems / nautilus_trader

A high-performance algorithmic trading platform and event-driven backtester
https://nautilustrader.io
GNU Lesser General Public License v3.0
1.71k stars 402 forks source link

Betfair bugfix: Reload cache as a dict of venue and client order ids #1608

Closed imemo88 closed 2 months ago

imemo88 commented 2 months ago

Pull Request

Reload venue order and client order id cache correctly after a reconnection event. Please see #betfair (discord) where the issue highlighted a bit better

Type of change

[x] Bug fix

How has this change been tested?

In production

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

cjdsellers commented 2 months ago

Hi @imemo88

Thanks so much for the fix!

Looks like we just have pre-commit failing so far. You can run pre-commit with:

make pre-commit

or

pre-commit run --all-files

You can also run the following to install the git hook to ensure it always runs on local commits too:

pre-commit install

It looks like some auto-formatting from black will occur, then you can push another commit.