nautechsystems / nautilus_trader

A high-performance algorithmic trading platform and event-driven backtester
https://nautilustrader.io
GNU Lesser General Public License v3.0
1.97k stars 450 forks source link

`DockerizedIBGateway` container reference typo #1889

Closed Xepheryy closed 1 day ago

Xepheryy commented 2 weeks ago

Bug Report

Expected Behavior

The string in the DockerizedIBGateway.IMAGE will allow us to pull the correct container from here

Actual Behavior

It attempts to pull a container that does not exist as the tag [stable] is not attached to any container image.

Steps to Reproduce the Problem

  1. Set up per-requisites required to run the DockerizedIBGateway
  2. Attempt to run the code that calls the initial set up of the container as outlined in the documentation for IBKR integration

Specifications

cjdsellers commented 2 weeks ago

Hi @Xepheryy

Thanks for the report.

Any thoughts here @rsmb7z or @benjaminsingleton?

rsmb7z commented 2 weeks ago

@cjdsellers It seems there have been some changes on the Docker repository side, as this used to work before. I'll check it out and provide an update over the weekend.

Xepheryy commented 2 weeks ago

@rsmb7z I already have a working fix, its a really simple one. Should I create a PR ?

cjdsellers commented 2 weeks ago

Hi @Xepheryy

Absolutely, that would be much appreciated!

Xepheryy commented 1 week ago

Hi, sorry for the delay it seems like the simple fix has some regressions. I'll continue to investigate.

rsmb7z commented 1 day ago

Hi @Xepheryy, I've tested the container, and it's working fine. The only recent change is that IB now requires Push Authentication for paper accounts, which wasn't the case before. While this enhances the realism by mimicking the real account experience, the issue arises if the authentication isn't completed before the notification expires—something that previously needed external handling for live accounts. Now that paper accounts also require authentication, the Docker container shouldn't be tightly coupled with Nautilus.

I've made some updates in #1940 to allow the option to load any custom image through config.