nautilus-cyberneering / secure-git-guide

A collections of articles about Git, GitHub and GPG focused on security.
https://secure-git.guide
8 stars 5 forks source link

fix article links colour on dark mode #84

Open grmbyrn opened 11 months ago

grmbyrn commented 11 months ago

I have updated the article titles to appear in white when the page is in dark mode. This change ensures better visibility and accessibility for users.

Changes Made:

Adjusted the CSS for article titles to use white colour in dark mode.

Additional Notes:

Titles appeared white in dark mode when page viewed locally, but black when viewed on https://secure-git.guide/ so it was tricky to identify the cause. If the issue persists, please let me know.

cgbosse commented 11 months ago

Hi @grmbyrn,

If this is related to issue #78 then I think there is a different way of referencing this. Please ask @josecelano how to do this properly. I assume that this is the solution that has not been merged yet that you mentioned to have done in #78 .

Thank you.

grmbyrn commented 11 months ago

Hi @cgbosse, yes this is the pull request mentioned in #78. @josecelano, is there another way this should be referenced?

josecelano commented 11 months ago

Hi @cgbosse, yes this is the pull request mentioned in #78. @josecelano, is there another way this should be referenced?

image

josecelano commented 11 months ago

Hi @grmbyrn if you run npm run preview is still not working:

image

josecelano commented 11 months ago

With dev:

image

With preview:

image