search

nautilus / gateway

A federated api gateway for graphql services. https://gateway.nautilus.dev/
MIT License
397 stars 49 forks source link

Support File Uploads inside of Inputs #133

Closed mfinley3 closed 3 years ago

mfinley3 commented 3 years ago

Closes #131

Adds support for:

scalar Upload

input FilesInput {
    files:   [Upload!]!
    file:    Upload!
}
type Mutation {
    uploadMultiInput(input: FilesInput!): [String!]!
}

Before merging this we should merge: https://github.com/nautilus/graphql/pull/17 then tag the repo and update deps here

Signed-off-by: mfinley mfinley@octolabs.io

mfinley3 commented 3 years ago

@AlecAivazis Thanks for taking a look at these PRs so quickly! I've updated the nautilus/graphql version here to the latest tag you've created. Let me know if you have any feedback on these changes!

Also what would you'd like me to do about the coveralls check that's failing? I'm not quite sure where to improve the coverage; it looks like nothings been uncovered and I've appeared to hit all of the lines I added.

AlecAivazis commented 3 years ago

@mfinley3 don't worry about the failing coveralls check, 0.007 is basically the same value. One of these days I'll look into adding some buffer to this check but I can just push it through for now.

Thanks for the contribution!

mfinley3 commented 3 years ago

Awesome - thanks @AlecAivazis :)