Build with Go 1.18, compatible with Go 1.13

nautilus / gateway

A federated api gateway for graphql services. https://gateway.nautilus.dev/

MIT License

397 stars 49 forks source link

Build with Go 1.18, compatible with Go 1.13 #161

Closed JohnStarich closed 2 years ago

JohnStarich commented 2 years ago

Bumps the Go version for builds to the latest, Go 1.18.
Fixes golang.org/x/sys version for Go 1.18.
The go X.Y line in go.mod enforces our backward compatibility guarantee. Documented in README now.

JohnStarich commented 2 years ago

Hey @AlecAivazis! I started taking a look at doing https://github.com/nautilus/gateway/issues/143 and hit some issues with the latest version of Go.

The golang.org/x/sys change was the main thing. I thought it might be nice to upgrade the build system as well to catch issues like that one.

If you like, I can extend it in GitHub Actions to run tests on several different Go versions too.

AlecAivazis commented 2 years ago

Thanks for updating this @JohnStarich! I'll go ahead and merge/deploy it with these changes and you can add more environments in a separate PR - sound good?

JohnStarich commented 2 years ago

Sounds good! Thanks!