Closed sGy1980de closed 1 year ago
Seems like there's a test with flaky coverage. It's complaining about 2 lines in http.go
I did not touch at all.
Other than my question and these really minor comment updates, this looks great 💯
Don't worry about the coverage check, I agree it's probably a flaky coverage spot.
Hey @JohnStarich,
to be honest, I just spotted the TestExecutor_insertIntoAliasedListFragmentSpreads
first. I was scanning the tests for examples where the code would hit the problem. Later I found the other example and decided to adopt this one as well, since there this flip/flop (service A/Service B) thingy kicks in.
Thx for the review
Your fix is released as v0.3.4
🎉
This fixes #181
add check for alias on list elements