search

nautilus / gateway

A federated api gateway for graphql services. https://gateway.nautilus.dev/
MIT License
397 stars 49 forks source link

fix bug "aliases not recognized when federating list responses" #182

Closed sGy1980de closed 1 year ago

sGy1980de commented 1 year ago

This fixes #181

add check for alias on list elements

sGy1980de commented 1 year ago

Seems like there's a test with flaky coverage. It's complaining about 2 lines in http.go I did not touch at all.

JohnStarich commented 1 year ago

Other than my question and these really minor comment updates, this looks great 💯

Don't worry about the coverage check, I agree it's probably a flaky coverage spot.

sGy1980de commented 1 year ago

Hey @JohnStarich,

to be honest, I just spotted the TestExecutor_insertIntoAliasedListFragmentSpreads first. I was scanning the tests for examples where the code would hit the problem. Later I found the other example and decided to adopt this one as well, since there this flip/flop (service A/Service B) thingy kicks in.

Thx for the review

JohnStarich commented 1 year ago

Your fix is released as v0.3.4 🎉