search

nautobot / helm-charts

Helm Charts for using Nautobot in Kubernetes environments.
https://docs.nautobot.com/projects/helm-charts/en/stable/
Apache License 2.0
23 stars 18 forks source link

Enhancement Automatic Roll of Deployments #440

Open rifen opened 2 days ago

rifen commented 2 days ago

As a Nautobot Helm Deployment maintainer I am having inconsistent deployments depending on what values I change using helm upgrade. It isn't breaking but it can be annoying.

Found a recommendation from the Helm Docs: https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments

Seems like it would be straight forward to implement in this chart.

I couldn't find anywhere where it was utilizing this in any of the deployment charts eg. https://github.com/nautobot/helm-charts/blob/42413335dd84fe1e8fb6dc5cd11fdc27cda8c1f1/charts/nautobot/templates/celery-deployment.yaml#L8

But maybe it isn't needed 🤷🏻.

Submitting this for some extra 👀

ubajze commented 1 day ago

Thank you for opening an issue.

I want to make sure I understand the problem correctly. If you change something that only updates a ConfigMap, your Deployments are not restarted, and a new environmental variable is not injected into pods. Is that correct?

If this is the case, it is a reasonable ask.

In the meantime, you can probably deploy a tool like Reloader for example: https://github.com/stakater/Reloader