search

nautobot / nautobot-ansible

Ansible Collection for managing Nautobot Data
https://nautobot-ansible.readthedocs.io/en/latest/
GNU General Public License v3.0
40 stars 31 forks source link

Fix ssl_verify to align with pynautobot in a version compatible with Nautobot v1.x #341

Closed joaopsys closed 2 months ago

joaopsys commented 2 months ago

Basically applying this PR - https://github.com/nautobot/nautobot-ansible/pull/269 - to the LTM nautobot-ansible release since https://github.com/nautobot/nautobot-ansible/pull/269 was only applied on versions compatible with Nautobot v2

Without this change, nautobot-ansible 4.5.0 doesn't work when used with the latest version of Nautobot LTM (1.6.x) as well as pynautobot 1.5.x

joewesch commented 2 months ago

Similar to the PR you linked, we should update pynautobot to ^1.5.1 for poetry as it includes the SSL change.

joewesch commented 2 months ago

Actually, go ahead and change it to ^1.5.2 to deal with the new auth changes as well.

joaopsys commented 2 months ago

Actually, go ahead and change it to ^1.5.2 to deal with the new auth changes as well.

Done!

joewesch commented 2 months ago

Please run a poetry lock to generate a new lock file as well.

joaopsys commented 2 months ago

Please run a poetry lock to generate a new lock file as well.

I noticed the pyproject.toml I was using (straight from https://github.com/nautobot/nautobot-ansible/tree/v4.5.0) was not the same as the one in https://github.com/nautobot/nautobot-ansible/tree/ltm-1.6 so I have updated it now to match and ran poetry lock as advised. Let me know if there's anything else I should do

joewesch commented 2 months ago

It is still showing file conflicts. You may want to rebase off ltm-1.6.

joaopsys commented 2 months ago

Let's try this again :) https://github.com/nautobot/nautobot-ansible/pull/344