search

nautobot / nautobot-ansible

Ansible Collection for managing Nautobot Data
https://nautobot-ansible.readthedocs.io/en/latest/
GNU General Public License v3.0
40 stars 31 forks source link

Fix ssl_verify to align with pynautobot in the LTM version compatible with Nautobot v1.x #344

Closed joaopsys closed 2 months ago

joaopsys commented 2 months ago

Basically applying this PR - https://github.com/nautobot/nautobot-ansible/pull/269 - to the LTM nautobot-ansible release since https://github.com/nautobot/nautobot-ansible/pull/269 was only applied on versions compatible with Nautobot v2

Without this change, nautobot-ansible 4.5.0 doesn't work when used with the latest version of Nautobot LTM (1.6.x) as well as pynautobot 1.5.x

joewesch commented 2 months ago

Invalid author string. Must be in the format: John Smith john@example.com

It looks like the author string is wrong in pyproject.toml: https://github.com/nautobot/nautobot-ansible/blob/91e6d502db1223b22293b3b9226e3e32b86d535c/pyproject.toml#L5

If you could please fix that in this PR.

joaopsys commented 2 months ago

Invalid author string. Must be in the format: John Smith john@example.com

It looks like the author string is wrong in pyproject.toml:

https://github.com/nautobot/nautobot-ansible/blob/91e6d502db1223b22293b3b9226e3e32b86d535c/pyproject.toml#L5

If you could please fix that in this PR.

Done, we got another error and I am clueless :)

joewesch commented 2 months ago

Run black . to format all existing files. It's a change in the latest version of black that wants a blank line after the module docstrings.

joaopsys commented 2 months ago

Run black . to format all existing files. It's a change in the latest version of black that wants a blank line after the module docstrings.

Done, I think

joewesch commented 2 months ago

It looks like you will also need to incorporate a similar monkeypatch to what we have for 2.0 (but with 1.6 obviously): https://github.com/nautobot/nautobot-ansible/blob/24cda0435a2cd7e967e2a78fe544bc01ed9d5ad6/tests/unit/conftest.py#L16-L18

joewesch commented 2 months ago

Here is a commit I did to fix the lookup tests in 2.x: https://github.com/nautobot/nautobot-ansible/commit/830da99fa5bbb7ea538d12d4de6c7e09ca16dc24

joewesch commented 2 months ago

Thank you @joaopsys for your patience and keeping up with all of the changes needed.

joaopsys commented 2 months ago

Thank you for your help @joewesch, I basically copy pasted a lot of your code 😄