nautobot / nautobot-app-design-builder

https://docs.nautobot.com/projects/design-builder/en/latest/
Other
8 stars 2 forks source link

[ltm-1.6] Import mode for existing data #178

Closed chadell closed 1 month ago

chadell commented 2 months ago

This PR adds a new feature to import existing data into a new Design Deployment

TODOs:

abates commented 1 month ago

Before I can approve this I'd like to see a test (or confirm that there is a test) that does the following:

  1. Creates a bunch of objects outside of a design
  2. Runs a design in import mode that will create some objects that were created already in step 1. The portions of the design that correspond to step 1 should have no action tags (default create).
  3. Confirms that there are no errors and that the objects that should have been imported now show as "owned" by the design.
chadell commented 1 month ago

Before I can approve this I'd like to see a test (or confirm that there is a test) that does the following:

  1. Creates a bunch of objects outside of a design
  2. Runs a design in import mode that will create some objects that were created already in step 1. The portions of the design that correspond to step 1 should have no action tags (default create).
  3. Confirms that there are no errors and that the objects that should have been imported now show as "owned" by the design.

This test https://github.com/nautobot/nautobot-app-design-builder/pull/178/files#diff-a45426cea1233c01ee8f3f6db38123c56701edf1f027f129206094df76415bffR124 does it but it's not "a bunch" but just one object. Do you think is relevant to have more than one?

Kircheneer commented 1 month ago

Further open points

Kircheneer commented 1 month ago

Closing in favor of #181