search

nautobot / nautobot-app-device-onboarding

Device Onboarding Plugin for Nautobot
https://docs.nautobot.com/projects/device-onboarding/en/latest/
Other
44 stars 31 forks source link

Device Onboarding 4.0 is Not Compatible with Latest Secrets Providers #217

Closed bryanculver closed 3 months ago

bryanculver commented 3 months ago

This wasn't present in 3.0.1 of Device Onboarding:

https://github.com/nautobot/nautobot-app-device-onboarding/blob/995c73906a7850f71faa7ab4108c541c1ec1783a/pyproject.toml#L37

Secrets Providers is already on 3.1: https://github.com/nautobot/nautobot-app-secrets-providers/releases

scetron commented 3 months ago

@jeffkala any issue with moving this to *?

jeffkala commented 3 months ago

@jeffkala any issue with moving this to *?

No issues that I'm aware of.

bryanculver commented 3 months ago

@jeffkala any issue with moving this to *?

No issues that I'm aware of.

I am not finding in the code where nautobot_secrets_providers is imported from directly. Is it even required?

The framework for Secrets is provided by Core itself.

Dav-C commented 3 months ago

I suspect this was used in testing but not intended to be in the final release.

nkallergis commented 3 months ago

Adding a PR for Secrets Provider in order to resolve dependency issue: https://github.com/nautobot/nautobot-app-secrets-providers/pull/146