search

nautobot / nautobot-app-golden-config

Golden Configuration App for Nautobot.
https://docs.nautobot.com/projects/golden-config/en/latest/
Other
98 stars 56 forks source link

Improve view coverage in test_views.py #717

Open glennmatthews opened 7 months ago

glennmatthews commented 7 months ago

Environment

Proposed Functionality

nautobot/nautobot#5254 caused several GC views to raise exceptions when accessed, however upstream CI testing of this repository remained "green"/passing in full despite this issue. It would be good to implement at least basic sanity tests for all views in this app (inheriting a test for each view from nautobot.apps.testing.ViewTestCases would be a good starting point) in order to more rapidly detect fundamental breakage of the app.

Use Case

More comprehensive testing, earlier detection of fundamental breakage.

itdependsnetworks commented 7 months ago

Would it be ok to track this on cookiecutter? I checked DLM, and it didn't have a contract test as an example, and I suspect this will be the case across many apps.